Skip to content

Complete sprint 1 exercises and fix errors in interpretation tasks #624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sofayas
Copy link

@sofayas sofayas commented Jun 29, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this tas

Changelist

This PR completes all assigned exercises and fixes in Sprint 1 of the Module-Structuring-and-Testing-Data coursework. Changes were made across key exercises, mandatory error corrections, and interpretation explanations. All code was tested and reviewed before committing.

✅ Key Changes:

  • Completed all tasks in Sprint-1/1-key-exercises/ (e.g. initials, random, paths, count)
  • Fixed syntax and logic errors in files under 2-mandatory-errors/
  • Answered all interpretation questions in 3-mandatory-interpret/ with full step-by-step breakdowns
  • Added supporting files for exercises like cardNumber.js, percentage-change.js, timeFormat.js, and more
  • Used proper string and number conversion methods (slice, substring, Number, etc.)
  • Followed best practices for formatting, naming, and commenting

🔍 Other Notes:

  • Code has been formatted with Prettier
  • All files were tested using node to ensure no syntax errors
  • Branch: coursework/sprint-1-

Questions

  1. Could you please review my explanation comments in the interpretation tasks? I want to make sure I'm understanding the logic clearly.
  2. Is my code formatting and variable naming consistent with good JavaScript practice?
  3. I tested everything with node, but I’m not sure if I missed any edge cases — is there anything you'd suggest testing differently?
  4. Are there any ways I can improve the readability or clarity of my answers?

@sofayas sofayas added the Needs Review Participant to add when requesting review label Jun 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Review Participant to add when requesting review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant